Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate *_changed? and *_previously_changed? sigs for belongs_to relations #1955

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Generate *_changed? and *_previously_changed? sigs for belongs_to relations #1955

merged 4 commits into from
Jul 16, 2024

Commits on Jul 11, 2024

  1. Generate belongs_to *_changed? sigs 

    Models with a belongs_to relation now have a `_changed?` and `_previously_changed?` method since rails/rails#42751. This shipped in Rails 7, see https://github.com/rails/rails/blob/b84fa1083ca7e6422356fdf80cb33751d0a23eff/activerecord/CHANGELOG.md#rails-700alpha1-september-15-2021.
    @cheshire137
    cheshire137 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4f95610 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Only include methods for Rails 7+ 

    Thanks to https://github.com/Shopify/tapioca/pull/1955/files#r1676329205
    @cheshire137
    cheshire137 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    40b1203 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Drop trim_mode in tests 

    https: //github.com/Shopify/pull/1955#discussion_r1678141642
Co-Authored-By: Ufuk Kayserilioglu <[email protected]>
    @cheshire137 @paracycle
    cheshire137 and paracycle committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d49e1d8 View commit details
    Browse the repository at this point in the history

  2. Check if specific methods defined, to add sigs 

    https: //github.com/Shopify/pull/1955#discussion_r1678141696
Co-Authored-By: Ufuk Kayserilioglu <[email protected]>
    @cheshire137 @paracycle
    cheshire137 and paracycle committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    588af36 View commit details
    Browse the repository at this point in the history