Handle deferred route drawing in URL helpers DSL compiler #1899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The URL helpers DSL compiler appears broken after rails/rails@e97db3b introduced deferred route drawing.
This leads to all helper methods being stripped from
GeneratedUrlHelpersModule
andGeneratedPathHelpersModule
.Implementation
Ensure routes are loaded before generating
GeneratedUrlHelpersModule
andGeneratedPathHelpersModule
.Tests
I was able to manually test this out in one of our Rails applications at @justworkshr.
Open to any ideas on how to unit test this behavior—it seems like the existing tests pass despite the change in Rails itself.