Fix engine loading for Rails 7.2 #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 7.2 changed `eager_load_paths` for `all_eager_load_paths` in this rails/rails@ebfca90
st0012
reviewed
Oct 30, 2023
st0012
approved these changes
Oct 30, 2023
andyw8
reviewed
Oct 31, 2023
Co-authored-by: Andy Waite <[email protected]>
KaanOzkan
approved these changes
Oct 31, 2023
andyw8
approved these changes
Oct 31, 2023
We do test against Rails main, so this should have been caught already. But, it seems our existing tests weren't able to catch this failure, since Rails main builds only have a single unrelated failure even before this PR was merged. 🤔 |
|
We probably don't have tests related to engine files under the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Commit rails/rails@ebfca90 renamed
eager_load_pathstoall_eager_load_paths.For Rails applications pointing to
main, Tapioca ends up not loading all engine pathsImplementation
The idea of the implementation is to switch to using the Rails 7.2 name of the configuration and just ensure it always exists even for older versions.
Tests
I'm not sure how we can write a test for this given that 7.2 has no releases yet. I did test this in Core though.