Add postgres Uuid to be translated as String by tapioca dsl #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
KaanOzkan
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Looking at sorbet-rails string looks correct. We don't utilize postgres internally so if this branch works on your project we can merge it.
vinistock
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Rails application I'm working on utilizes UUIDs as described in this tutorial: link to the tutorial. Unfortunately, Tapioca's DSL couldn't correctly identify the column types generated by PostgreSQL. This led to a situation where primary and foreign keys were classified as T.untyped, disabling these attributes type checking.
Implementation
To resolve this issue, I've introduced a specific verification for the column type, "ActiveRecord::ConnectionAdapters::PostgreSQL::OID::Uuid," which ensures that the affected columns are correctly recognized as ::String by Tapioca, thereby enabling accurate type checking.
Tests
As i am new to this repository, I couldn't find an established location for adding tests since there are no existing ones for the active_record_column_type_helper.rb file. I would appreciate guidance on the appropriate method for adding tests to this file or whether it's a common practice in this context.