Support Composite Primary keys in ActiveRecordColumns compiler #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
reviewed
Sep 7, 2023
There was a problem hiding this comment.
I think it's okay to move to Rails main. We currently test against it so that logic would have to to be replaced with Rails 7: https://github.com/Shopify/tapioca/blob/main/gemfiles/Gemfile-rails-main.
There are some unrelated failures this PR will have to fix due to Rails main. It could be worth doing that work in another PR.
gmcgibbon
force-pushed
the
cpk_support
branch
2 times, most recently
from
47cec53
to
e475ccf
Compare
Composite key ids are tuples consisting of multiple columns.
In Active Record, the primary key column is always referenceable via id attribute methods.
gmcgibbon
force-pushed
the
cpk_support
branch
from
e475ccf
to
3dfc8c2
Compare
|
This build is green now, and the CPK test is conditionalized to only run on main for now. |
|
The changes look good to me, but can we please test DSL generation on Core before merging? Just to be on the safe side. |
KaanOzkan
approved these changes
Sep 11, 2023
|
Done. The output looks correct to me, so I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support Active Record composite primary keys in
ActiveRecordColumnscompiler.Implementation
I imagine using Rails edge may not be ideal, and if it isn't, we can look at merging this closer to when CPK is released. Due to how the compiler works, I would also consider renaming it to
ActiveRecordAttributesinstead.Tests
The implementation inadvertently fixed a bug where the generated attribute methods don't include
idwhen using a non-id primary key. Active Record always has anidmethod defined via https://github.com/rails/rails/blob/bc2892ab4557136a959e95c329c2dcc0133c7585/activerecord/lib/active_record/attribute_methods/primary_key.rb.