Add support for loading custom DSL extensions #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Olivier, Thanks so much for the contribution. This looks like a good addition to the repo. Given this is a new feature, could you please spend a bit of time adding some documentation to the readme to ensure that this is discoverable? Also regarding tests, it looks like @Morriar had started creating some in this commit if you wanted to pluck what would be relevant to this change. |
olivier-thatch
force-pushed
the
olivier-load-custom-extensions
branch
from
d113ad4
to
58d2412
Compare
|
@bitwise-aiden I updated the README and added a couple of tests. Let me know what you think! |
Morriar
reviewed
Aug 15, 2023
olivier-thatch
force-pushed
the
olivier-load-custom-extensions
branch
from
58d2412
to
4cacf62
Compare
bitwise-aiden
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds support for loading custom extension classes in addition to Tapioca's built-in extensions. See #1600 for more details.
Implementation
Updated
Tapioca::Loaders::Dsl.load_dsl_extensionsto behave similarly toTapioca::Loaders::Dsl.load_dsl_compilersand require all Ruby files found insorbet/tapioca/extensions.Tests
Added automatests to
spec/tapioca/cli/dsl_spec.rb.