Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Ruby 2.7 support #1567

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Drop Ruby 2.7 support #1567

merged 1 commit into from
Jul 18, 2023

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Jul 12, 2023

Ruby 2.7 has been EOL since 31 Mar 2023.

andyw8
andyw8 commented Jul 12, 2023
View reviewed changes
lib/tapioca/sorbet_ext/generic_name_patch.rb
@@ -191,19 +191,6 @@ def initialize(context, type, variance, fixed, lower, upper, bounds_proc)
sig { returns(T.nilable(String)) }
def name
constant_name = super

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found by grepping for 2.7.

@andyw8 andyw8 marked this pull request as ready for review July 12, 2023 18:32
@andyw8 andyw8 requested a review from a team as a code owner July 12, 2023 18:32
@andyw8 andyw8 requested review from Morriar and st0012 July 12, 2023 18:32
KaanOzkan
KaanOzkan reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@KaanOzkan KaanOzkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe gemspec and rubocop config needs to be updated.

@andyw8 andyw8 force-pushed the andyw8/drop-ruby-2.7-support branch from 541984f to 375d0c2 Compare July 12, 2023 19:13
@andyw8 andyw8 merged commit 9649fc4 into main Jul 18, 2023
@andyw8 andyw8 deleted the andyw8/drop-ruby-2.7-support branch July 18, 2023 13:34
@andyw8 andyw8 added the breaking-change Non-backward compatible change label Jul 18, 2023
@shopify-shipit shopify-shipit bot temporarily deployed to production September 13, 2023 22:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan KaanOzkan left review comments

@Morriar Morriar Morriar approved these changes

@paracycle paracycle paracycle approved these changes

@st0012 st0012 Awaiting requested review from st0012 st0012 is a code owner automatically assigned from Shopify/sorbet

Assignees
No one assigned
Labels
breaking-change Non-backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyw8 @paracycle @Morriar @KaanOzkan