Stop generating new
singleton methods for abstract classes
#1524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1507
Implementation
When generating methods for a constant, we check to see if:
:new
:abstract
or:interface
Class
If all these conditions are satisfied, then we skip the definition of the
new
method, since generating it messes with Sorbet's internal handling of hownew
method calls behave.Tests
Added a new test and updated existing tests to reflect the behaviour change.