feat: consistently define fetch_multi_by
#1468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following Shopify/identity_cache#534, IdentityCache will define
fetch_multi_by
forcache_index
invocations regardless of the number of keys included in the index. (Previously only single-index keys were supported.)We should lift the
field_length
restriction accordingly.Implementation
Removes the
field_length == 1
restriction (as well as thefield_length
variable designation, which is now useless).Tests
Nothing changed.Updated a unit test implicitly testing this behavior in 64983d4.