-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patch to Ruby version in dev.yml
#1274
Conversation
CI failures seem unrelated. I was able to push an empty commit based on It consistently fails only on the following test, only on builds using Rails 6.1:
Update: Resolving this is being worked on in #1270 |
@@ -3,7 +3,7 @@ name: tapioca | |||
type: ruby | |||
|
|||
up: | |||
- ruby: '3.1' | |||
- ruby: '3.1.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the patch, Dev downloads a precompiled binary, but without it seems to choose to compile from source, which seems unnecessary.
Should we add this as a comment explaining why we use this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️ I've never seen it in other projects. This tends to be "latest stable" anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Searching for x.y
Ruby versions in dev.yml
across our org only turns up 5 matches, so I think it's safe to say this is uncommon.
With the patch, Dev downloads a precompiled binary, but without it seems to choose to compile from source, which seems unnecessary.
3093ba7
to
302aafe
Compare
Motivation
With the patch, Dev downloads a precompiled binary, but without it seems to choose to compile from source, which seems unnecessary.
Implementation
The config is updated to Ruby 3.1.2, the latest in the 3.1 releases.
Tests
🎩'd locally.