dev: clean up Gemfile.lock platforms #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove `universal-darwin-22` because this only applies to the Apple-installed version of Ruby which nobody should be using to develop Tapioca - add `x86_64-darwin` for our friends without M1s - change `arm64-darwin-21` to the more generic `arm64-darwin` Note that none of the gems locked in this bundle have changed.
rafaelfranca
approved these changes
Oct 20, 2022
KaanOzkan
approved these changes
Oct 20, 2022
st0012
approved these changes
Oct 20, 2022
|
Thank you. I'm not sure that dependabot won't remove these in the future but let's try 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Updating the Gemfile.lock platforms to be in line with what we expect development environments to be.
universal-darwin-22because this only applies to the Apple-installed version of Ruby which nobody should be using to develop Tapiocax86_64-darwinfor our friends without M1sarm64-darwin-21to the more genericarm64-darwinNote that none of the gems locked in this bundle have changed.
Implementation
See above.
Tests
No functional change, existing tests are sufficient.