Add explanation in readme what ConstantType is for #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
reviewed
Oct 3, 2022
paracycle
approved these changes
Oct 3, 2022
|
I signed the CLA, that step should be green once re-run. |
egiurleo
reviewed
Oct 4, 2022
egiurleo
approved these changes
Oct 5, 2022
It's listed in the example and not too hard to deduce by copy-pasting the example and tweaking until it works (or have 'srb tc' yell at you), but it is never actually explained. Co-authored-by: Ufuk Kayserilioglu <[email protected]> Co-authored-by: Emily Samp <[email protected]>
bdewater
force-pushed
the
readme-constant-type
branch
from
b9822fa
to
383df6a
Compare
|
@bdewater Would you mind rebasing? I just merged a fix for the failing CI tests and I think CI got stuck last night. |
|
It is just a doc change so I am merging this anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's listed in the example and not too hard to deduce by copy-pasting the example and tweaking until it works (or have
srb tccomplain), but it is never actually explained.cc @paracycle from our Slack convo