Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable trackers in commands that don't need them #1190

Merged
merged 6 commits into from
Sep 28, 2022

Conversation

paracycle
Copy link
Member

Motivation

Related to: #1181

Most of our commands don't need the overhead of Tapioca runtime trackers constantly running in the background and doing processing. This PR implements and makes use of a mechanism to disable all trackers for commands that don't need them.

Implementation

  1. Add a Tracker module that is responsible for registration and disabling of an individual tracker module.
  2. Make all trackers use that Tracker module and respect the enabled? state.
  3. Add a CommandWithoutTracker base class that disables all trackers during initialization.
  4. Make all commands that don't need trackers (basically all commands except GemCommand) subclass from CommandWithoutTracker.

Tests

No added tests.

@paracycle paracycle requested a review from a team as a code owner September 28, 2022 19:42
@paracycle paracycle merged commit e6f39e1 into main Sep 28, 2022
@paracycle paracycle deleted the uk-disable-trackers-in-commands branch September 28, 2022 20:37
@shopify-shipit shopify-shipit bot temporarily deployed to production September 29, 2022 19:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants