Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Fix typo #1183

Merged
merged 1 commit into from
Sep 23, 2022
Merged

README: Fix typo #1183

merged 1 commit into from
Sep 23, 2022

Conversation

issyl0
Copy link
Contributor

@issyl0 issyl0 commented Sep 23, 2022

Motivation

  • I was reading the docs about bin/tapioca gems --all and spotted the word "previously" mistyped as "previsouly".

Implementation

  • Fixed the typo.

Tests

  • Not applicable, just a documentation change.

@issyl0 issyl0 requested a review from a team as a code owner September 23, 2022 13:49
@issyl0
Copy link
Contributor Author

issyl0 commented Sep 23, 2022

I signed the individual CLA, but I can't trigger a rerun of the CI check like it asks me to.

paracycle
paracycle approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@paracycle paracycle merged commit caddfba into Shopify:main Sep 23, 2022
@issyl0 issyl0 deleted the patch-1 branch September 23, 2022 15:08
@shopify-shipit shopify-shipit bot temporarily deployed to production September 29, 2022 19:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@issyl0 @paracycle