Generate the right signature for generics with fixed type members #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
force-pushed
the
rm-fixed-type-member
branch
3 times, most recently
from
74dbefa
to
7e082c8
Compare
When a generic has a fixed type member, Sorbet doesn't accept it as argument in the `#[]` method, so we can't be passing `T.untyped` as argument.
rafaelfranca
force-pushed
the
rm-fixed-type-member
branch
from
7e082c8
to
662b721
Compare
Morriar
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a generic has a fixed type member, Sorbet doesn't accept it as argument in the
#[]method, so we can't be passingT.untypedas argument.Implementation
I filtered all the type variables that didn't had
:fixedas key in the bounds arguments when generating the signature.