Don't worry about filtering ActiveRecord::Base

Shopify · Sep 12, 2023 · 41f8e5f · 41f8e5f
1 parent c2340a8
commit 41f8e5f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/tapioca/dsl/compilers/active_model_validations_confirmation.rb b/lib/tapioca/dsl/compilers/active_model_validations_confirmation.rb
@@ -62,8 +62,7 @@ class << self
           def gather_constants
             # Collect all the classes that include ActiveModel::Validations
             all_classes.select do |c|
-              c < ActiveModel::Validations &&
-                c.name.to_s != "ActiveRecord::Base"
+              c < ActiveModel::Validations
             end
           end
         end

diff --git a/spec/tapioca/dsl/compilers/active_model_validations_confirmation_spec.rb b/spec/tapioca/dsl/compilers/active_model_validations_confirmation_spec.rb
@@ -27,7 +27,7 @@ class ShopWithValidations
                 class ShopWithActiveRecord < ActiveRecord::Base
                 end
               RUBY
-              assert_equal(["ShopWithActiveRecord", "ShopWithValidations"], gathered_constants)
+              assert_equal(["ActiveRecord::Base", "ShopWithActiveRecord", "ShopWithValidations"], gathered_constants)
             end
           end
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,7 +27,7 @@ class ShopWithValidations @@
                     class ShopWithActiveRecord < ActiveRecord::Base
                     end
                   RUBY
-                  assert_equal(["ShopWithActiveRecord", "ShopWithValidations"], gathered_constants)
+                  assert_equal(["ActiveRecord::Base", "ShopWithActiveRecord", "ShopWithValidations"], gathered_constants)
                 end
               end
@@ Expand Down @@