Merge pull request #36 from Shopify/content-no-strings-default

Disable `content-no-strings` rule by default

CHANGELOG.md

@@ -2,9 +2,9 @@
 
 <!-- ## [Unreleased] -->
 
-## [5.1.0] - 2018-07-05
+## [5.1.1] - 2018-07-10
 
-- Added a new custom rule `plugin/content-no-strings` that disallows hard-coded strings as values for the `content` property. This prevents internationalization issues. Keywords are still allowed.
+- Added a new custom rule `shopify/content-no-strings` that disallows hard-coded strings as values for the `content` property. This prevents internationalization issues. Keywords are still allowed. The rule is not enabled by default. 
 
 The following patterns are considered violations:
 
@@ -26,6 +26,10 @@ The following patterns are _not_ considered violations:
 .foo::before { content: open-quote counter(section_counter) close-quote; }
 ```
 
+## [5.1.0] - 2018-07-05 [YANKED]
+
+- Use 5.1.1 instead.
+
 ## [5.0.1] - 2018-04-06
 
 - Updated dependency: stylelint-css (no breaking changes, only fixes)
@@ -168,7 +172,8 @@ property: <top> <right> <bottom> <left>
 * Initial release
 
 
-[Unreleased]: https://github.com/Shopify/stylelint-config-shopify/compare/v5.1.0...HEAD
+[Unreleased]: https://github.com/Shopify/stylelint-config-shopify/compare/v5.1.1...HEAD
+[5.1.1]: https://github.com/Shopify/stylelint-config-shopify/compare/v5.1.0...v5.1.1
 [5.1.0]: https://github.com/Shopify/stylelint-config-shopify/compare/v5.0.1...v5.1.0
 [5.0.1]: https://github.com/Shopify/stylelint-config-shopify/compare/v5.0.0...v5.0.1
 [5.0.0]: https://github.com/Shopify/stylelint-config-shopify/compare/v4.0.0...v5.0.0

index.js

@@ -28,7 +28,7 @@ module.exports = {
     require('./rules/unit'),
     require('./rules/value'),
     {
-      'plugin/content-no-strings': true,
+      'shopify/content-no-strings': null,
     },
   ),
 };

plugins/content-no-strings/content-no-strings.js

@@ -1,6 +1,6 @@
 const stylelint = require('stylelint');
 
-const ruleName = 'plugin/content-no-strings';
+const ruleName = 'shopify/content-no-strings';
 
 const messages = stylelint.utils.ruleMessages(ruleName, {
   rejected: 'You must not hard-code unlocalized strings into the `content` property',

plugins/content-no-strings/content-no-strings.test.js

@@ -1,8 +1,8 @@
 const testRule = require('stylelint-test-rule-tape');
-const shopifyi18n = require('.');
+const contentNoStrings = require('.');
 
-testRule(shopifyi18n.rule, {
-  ruleName: shopifyi18n.ruleName,
+testRule(contentNoStrings.rule, {
+  ruleName: contentNoStrings.ruleName,
   config: true,
   skipBasicChecks: true,