Factorize HTTP client builder

lib/smart_todo.rb

@@ -9,6 +9,7 @@ module SmartTodo
   autoload :CLI,                      "smart_todo/cli"
   autoload :Todo,                     "smart_todo/todo"
   autoload :CommentParser,            "smart_todo/comment_parser"
+  autoload :HttpClientBuilder,        "smart_todo/http_client_builder"
 
   module Dispatchers
     autoload :Base,                   "smart_todo/dispatchers/base"

lib/smart_todo/events.rb

@@ -182,21 +182,11 @@ def spec_set
     end
 
     def rubygems_client
-      @rubygems_client ||= Net::HTTP.new("rubygems.org", Net::HTTP.https_default_port).tap do |client|
-        client.use_ssl = true
-        client.read_timeout = 30
-        client.ssl_timeout = 15
-        client.max_retries = 2
-      end
+      @rubygems_client ||= HttpClientBuilder.build("rubygems.org")
     end
 
     def github_client
-      @github_client ||= Net::HTTP.new("api.github.com", Net::HTTP.https_default_port).tap do |client|
-        client.use_ssl = true
-        client.read_timeout = 30
-        client.ssl_timeout = 15
-        client.max_retries = 2
-      end
+      @github_client ||= HttpClientBuilder.build("api.github.com")
     end
 
     def github_headers(organization, repo)

lib/smart_todo/http_client_builder.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require "net/http"
+
+module SmartTodo
+  # @api private
+  class HttpClientBuilder
+    class << self
+      def build(endpoint)
+        Net::HTTP.new(endpoint, Net::HTTP.https_default_port).tap do |client|
+          client.use_ssl = true
+          client.read_timeout = 30
+          client.ssl_timeout = 15
+          client.max_retries = 2
+        end
+      end
+    end
+  end
+end

lib/smart_todo/slack_client.rb

@@ -26,12 +26,7 @@ def initialize(response_body)
     # @param slack_token [String]
     def initialize(slack_token)
       @slack_token = slack_token
-      @client = Net::HTTP.new("slack.com", Net::HTTP.https_default_port).tap do |client|
-        client.use_ssl = true
-        client.read_timeout = 30
-        client.ssl_timeout = 15
-        client.max_retries = 2
-      end
+      @client = HttpClientBuilder.build("slack.com")
     end
 
     # Retrieve the Slack ID of a user from his email

test/smart_todo/http_client_builder_test.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require "test_helper"
+require "tempfile"
+
+module SmartTodo
+  class HttpBuilderTest < Minitest::Test
+    def test_builds_http_client_with_proper_config
+      client = HttpClientBuilder.build("example.com")
+
+      assert_equal("example.com", client.address)
+      assert_equal(15, client.ssl_timeout)
+      assert_equal(30, client.read_timeout)
+      assert_equal(2, client.max_retries)
+    end
+  end
+end