Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Add 'webpack.postcss.plugins' config to set plugins for PostCSS #753

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

t-kelly
Copy link
Contributor

@t-kelly t-kelly commented Sep 13, 2018

What are you trying to accomplish with this PR?

Fixes #540

BREAKING: There is no longer separate production/dev configs. It is the job of the config to determine what it wants to return based on the value of process.env.NODE_ENV, which is equal to either production or development.

  • Move dev SASS config to parts/sass.js
  • Add 'webpack.postcss.plugins' which is passed directly to PostCSS.options.plugins
  • 'webpack.config.extend.prod' and 'webpack.config.extend.dev' config replaced with 'webpack.extend'
  • Refactor some tests

@t-kelly t-kelly self-assigned this Sep 13, 2018
@t-kelly t-kelly force-pushed the post-css-config branch 2 times, most recently from 48fa5a3 to 5bbd6a5 Compare September 13, 2018 18:18
@t-kelly t-kelly merged commit 8edd23a into master Sep 13, 2018
@t-kelly t-kelly deleted the post-css-config branch September 13, 2018 18:59
@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant