This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Fix single section files watch #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,7 @@ var config = { | |||
| icons: 'src/icons/**/*.svg', | |||
| templates: 'src/templates/**/*', | |||
| snippets: 'src/snippets/*', | |||
| sections: 'src/sections/*.liquid', | |||
| sections: 'src/sections/**/*', | |||
There was a problem hiding this comment.
Why does this need to update? We only ever want to watch the root level liquid file (unless it's a folder-built section)
There was a problem hiding this comment.
This is being used on the watch so we want to watch all files in the sections folder. AKA > any changes to sections in folders so that they compile or any changes to single liquid files so they get copied over.
|
👍 |
1 similar comment
|
👍 |
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* fix zip to use theme name * make theme root available in conffig * remove unrelated changes
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* fix zip to use theme name * make theme root available in conffig * remove unrelated changes
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* fix zip to use theme name * make theme root available in conffig * remove unrelated changes
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Shopify/themes-fed
Update to the section build to watch and deploy single section files. These changes also affect the build.