This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Deploy unbuilt theme #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about |
macdonaldr93
suggested changes
Nov 2, 2016
| @@ -8,10 +8,8 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@shopify/slate-tools": "^0.1.0", | |||
| "archiver": "^1.1.0", | |||
| "aws-sdk": "^2.6.12", | |||
| "mime-types": "^2.1.12" | |||
There was a problem hiding this comment.
could you switch these to use exact versions? Other than @shopify/slate-tools. We'd want that one to get latest.
| const DIST_DIR = 'upload'; | ||
| const SRC_FILES = [ | ||
| 'config-sample.yml' | ||
| ] |
|
|
||
| const SRC_DIRS = [ | ||
| 'src' | ||
| ] |
|
|
||
| archive.pipe(output); | ||
|
|
||
| for (var i in SRC_FILES) { |
| archive.file(SRC_FILES[i]); | ||
| } | ||
|
|
||
| for (var i in SRC_DIRS) { |
| ] | ||
|
|
||
| module.exports = (function() { | ||
| let output = fs.createWriteStream('upload/slate-unbuilt.zip'); |
There was a problem hiding this comment.
I think this would be const too. The value never gets reassigned
|
|
||
| output.on('close', () => { | ||
| console.log(`${archive.pointer()} total bites`); | ||
| }) |
|
|
||
| module.exports = (function() { | ||
| let output = fs.createWriteStream('upload/slate-unbuilt.zip'); | ||
| let archive = archiver('zip'); |
There was a problem hiding this comment.
this could prob be const too. Again never gets reassigned.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slate new themesecrets.jsonfile locally with the unencrypted AWS staging key.@Shopify/themes-fed