This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Add shipit deploys of built theme to S3 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shopify/themes-fed |
stevebosworth
force-pushed
the
staging
branch
from
d0c61a2 to
e689203
Compare
| AWS.config.credentials = new AWS.Credentials(config.access_key_id, config.secret_access_key); | ||
| AWS.config.region = 'us-east-1'; | ||
| } else { | ||
| console.log('Missing AWS secrets. You must decrypt the ejson first.'); |
There was a problem hiding this comment.
I think console.error would be better here
| ACL: 'public-read' | ||
| }, function (err, data) { | ||
| if (err) { | ||
| console.log(err, err.stack); |
stevebosworth
force-pushed
the
staging
branch
2 times, most recently
from
c7b7132 to
65089e8
Compare
stevebosworth
force-pushed
the
staging
branch
from
65089e8 to
d27308d
Compare
|
LGTM 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can use shipit to deploy versioned
slate-theme.zipto https://sdks.shopifycdn.com/slate/latest/slate-theme.zip or https://sdks-staging.shopifycdn.com/slate/latest/slate-theme.zip for the latest build orhttps://sdks[-staging].shopifycdn.com/slate/[version-number]/slate-theme.zipfor a versioned build.