This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
updated giftcard.js #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Apart from |
|
Oh wait, that should be fixed with the PR you pushed earlier, no? (I'll stop spamming now) |
cshold
suggested changes
Oct 20, 2016
| @@ -4,7 +4,7 @@ | |||
| * A file that contains scripts highly couple code to the Gift Card template. | |||
| */ | |||
|
|
|||
| theme.giftCard = (function() { | |||
| (function() { | |||
| if (!$('body').hasClass('template-giftcard')) { | |||
stevebosworth
force-pushed
the
move-giftcard-js
branch
from
f2ec6a5 to
f4901d6
Compare
stevebosworth
force-pushed
the
move-giftcard-js
branch
from
f4901d6 to
255bd39
Compare
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* updates dependencies * updated eeeeerrrrything
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* updates dependencies * updated eeeeerrrrything
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* updates dependencies * updated eeeeerrrrything
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Shopify/themes-fed
giftcard.jsinto it's own file and load it on the giftcard templatetheme.json giftcard templatedemo: https://checkout.shopify.com/gift_cards/8984760/77bb8c5fd0b314402f092280c388e17c