This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
add charset to stylesheet #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-kelly
approved these changes
Aug 22, 2017
|
Feel free to merge this @NathanPJF 😄 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
When developers add certain UTF-8 characters to their
theme.scssfile such as a trademark symbol©, an accent such asë, or a proud deer🦌, the stylesheet will not load properly on storefront.This was first noted in #204 and again in #241.
This PR adds the fix to the main stylesheet. Hopefully this will prevent future devs from running into this issue. 🙏🔮😄
Fix in action
Other notes
The broken stylesheet behaviour is only seen outside the theme editor. Within the theme editor, the stylesheet loads fine because the asset goes through a separate build process than storefront.
Checklist
For maintainers: