Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Sectionize header and footer #22

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Sectionize header and footer #22

merged 1 commit into from
Oct 11, 2016

Conversation

cshold
Copy link
Contributor

@cshold cshold commented Oct 11, 2016

Editor demo - https://carson-blocks.myshopify.com/admin/themes/101778947/editor

  • Remove references to logo_use_image checkbox setting
  • Update favicon setting and implementation
  • Move header and footer settings and markup to sections

Fixes https://github.com/Shopify/themes-dev-workflow/issues/699

@Shopify/themes-fed

@cshold cshold self-assigned this Oct 11, 2016
@stevebosworth
Copy link
Contributor

👍

@cshold cshold merged commit cb1edf5 into social Oct 11, 2016
@cshold cshold deleted the header-footer branch October 11, 2016 20:30
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
* used a different package for shrinkwrap

* fix linting and packages

* update slate dep

* update shrinkwrap

* update slate dep
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
* update to latest themekit

* fix environment flag

* bump version
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
* used a different package for shrinkwrap

* fix linting and packages

* update slate dep

* update shrinkwrap

* update slate dep
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
* update to latest themekit

* fix environment flag

* bump version
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
* used a different package for shrinkwrap

* fix linting and packages

* update slate dep

* update shrinkwrap

* update slate dep
t-kelly pushed a commit that referenced this pull request Jul 31, 2017
* update to latest themekit

* fix environment flag

* bump version
@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants