This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Add Jest for testing #193
Merged
Add Jest for testing #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertiful
approved these changes
Jul 11, 2017
mcpatten
reviewed
Jul 11, 2017
| globals: { | ||
| slate: {} | ||
| }, | ||
| }; |
|
Looks like CircleCI will call |
|
Actually I'll need to change |
|
just wanted to point out that, even though this is a super basic file, these are good tests 👍 Stick to testing the results of interactions with the interface methods. Focus on inputs & outputs - don't bother exposing or testing private methods directly - test them inferentially through expectations on the interface. You guys are on the right path here, keep it up 👏 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Fixes #180
For maintainers:
package.jsonversion in a separate PR, if applicable.