Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bump pylint #115

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ pytest-randomly==1.1.2

mock==2.0.0
mypy==0.501 ; python_version >= "3.3"
astroid>=1.6,<=2.0.4
astroid~=1.6,<=2.0.4
8 changes: 4 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,16 @@ def get_version():
],
test_suite='tests',
install_requires=[
'GitPython~=2.1.11',
'typing~=3.6.6 ; python_version<"3.5"',
'GitPython~=2.1',
'typing~=3.6 ; python_version<"3.5"',
'autopep8~=1.4',
],
extras_require={
':python_version>="3.0"': [
'pylint~=2.1.1'
'pylint~=2.6'
],
':python_version<"3.0"': [
'pylint~=1.9.3'
'pylint~=1.9'
]
}

Expand Down
2 changes: 1 addition & 1 deletion shopify_python/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from shopify_python import shopify_styleguide


__version__ = '0.5.3'
__version__ = '0.5.4'


def register(linter): # type: (lint.PyLinter) -> None
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/blank_line_after_class_required.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# pylint:disable=missing-docstring,invalid-name,too-few-public-methods,old-style-class
# pylint:disable=missing-docstring,invalid-name,too-few-public-methods
class SomeClass: # [blank-line-after-class-required]
def __init__(self):
pass
2 changes: 1 addition & 1 deletion tests/functional/global_variable.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# pylint: disable=invalid-name,too-few-public-methods,missing-docstring,unpacking-non-sequence,undefined-variable
# pylint: disable=old-style-class
# pylint:

my_int = 77 # [global-variable]

Expand Down
2 changes: 1 addition & 1 deletion tests/functional/lambda_func.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# pylint: disable=missing-docstring,deprecated-lambda
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.pylint.org/en/1.6.0/features.html
"This message can’t be emitted when using Python >= 3.0."

Alternatively, we can include a lambda_func.rc file with

[testoptions]
max_pyver=3.0

# pylint: disable=missing-docstring
import operator as o
import functools as f

Expand Down