Look deeper in a node's source position to detect the Truffle language being used. #92
Conversation
spec/seafoam/passes/truffle_spec.rb
Outdated
| end.map(&:dup) | ||
| before_truffle_argument_nodes = @graph.nodes.values.select do |n| | ||
| n.props[:synthetic_class] == "TruffleArgument" | ||
| ["example_polymorphic_receiver", "example_arith_operator"].each do |example| |
There was a problem hiding this comment.
So this expands to describe { before, it, it, before, it, it }...
which seems weird to me (I'm concerned that the contents of the second before block would overwrite the first).
Is it possible the before blocks are attached to the it blocks that follow (rather than just having both on the describe) (or even to the "each" block)?
There was a problem hiding this comment.
You're right. This is broken. I had confirmed that outer graalvm_version was correct, but @filename is wrong here. I'll take another look. I really wanted to avoid dynamically defining the specs, but if that's what necessary so be it.
There was a problem hiding this comment.
I wrapped everything in another describe block, this time printing out the context so it's easier to follow. I applied the same change to the GraalVM version stuff higher up. It makes the spec names a fair bit longer, but it actually looks quite nice in RubyMine (presumably VS Code as well).
Since everything ended up getting indented another level or two, it'd be best to enable the "hide whitespace" option when looking at the diff.
There was a problem hiding this comment.
I always ignore whitespace changes when looking at diffs :)
nirvdrum
force-pushed
the
improve-truffle-language-detection
branch
from
e96af0f to
2651ef8
Compare
nirvdrum
force-pushed
the
improve-truffle-language-detection
branch
from
2651ef8 to
9523129
Compare
No description provided.