Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up examples #37

Merged
merged 11 commits into from
Aug 8, 2021
Merged

Tidy up examples #37

merged 11 commits into from
Aug 8, 2021

Conversation

chrisseaton
Copy link
Contributor

Regenerate all examples, and give a script for doing so in the future. I want to create an archive of graphs so I can keep testing against different versions.

I haven't regenerated all Ruby graphs, as this is blocked by oracle/graal#3524.

Also fix the issue with node source info.

@chrisseaton chrisseaton merged commit 0b855f3 into master Aug 8, 2021
@chrisseaton chrisseaton deleted the tidy-examples branch August 8, 2021 15:52
@eregon
Copy link
Contributor

eregon commented Aug 9, 2021

I haven't regenerated all Ruby graphs, as this is blocked by oracle/graal#3524.

Wouldn't it be better if Ruby graphs used Primitive.blackhole (to make the value escape, but without the noise from a non-inlined call, similar to assigning to a field in Java), and for the graph which specifically wants to show non-inlined calls just disable inlining altogether?

@chrisseaton
Copy link
Contributor Author

I'd rather have one set of options to run the whole script instead of having to run some methods with some options and others with others.

@eregon
Copy link
Contributor

eregon commented Aug 9, 2021

Ah, https://chrisseaton.com/truffleruby/basic-truffle-graphs/ already uses Primitive.blackhole, I either forgot or did not see it yet :)
So opaque_call and instance_call are the two non-inlined on purpose methods left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants