Bump rubocop from 1.56.4 to 1.57.1 #582
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/bundler/rubocop-1.57.1
branch
from
e2becba to
4de71fd
Compare
github-actions
bot
added
the
config change
| <% if rubocop_version >= Gem::Version.new('1.57') %> | ||
| Style/SingleLineDoEndBlock: | ||
| Enabled: true | ||
| <% end %> |
There was a problem hiding this comment.
@rafaelfranca Trying something new here.
Typically, when a new cop is released, we enable or disable it, but that requires bumping the minimum RuboCop version (as older versions will complain they don't know about that cop).
As per our discussion about plugins, we'll have to take this approach to selectively enable plugin cops, as we won't be able to rely on Bundler/Rubygems to enforce any version requirement (without adding a dependency from rubocop-shopify to the various plugins, which we don't want to do).
Therefore, I'm trying out this approach here first.
Note that rubocop-shopify.gemspec has not changed, and CI is passing across all versions tested.
|
A newer version of rubocop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
| @@ -1,3 +1,5 @@ | |||
| <% rubocop_version = Gem.loaded_specs.fetch("rubocop").version %> | |||
There was a problem hiding this comment.
Is this the version on the bundle or in the system?
There was a problem hiding this comment.
It looks like the version of whatever the process is running, depending on if bundle exec (or equivalent binstub) is used or not.
Added logging and binstub
% git diff -U1
diff --git a/rubocop.yml b/rubocop.yml
index aab03ce..99bae8c 100644
--- a/rubocop.yml
+++ b/rubocop.yml
@@ -1,2 +1,4 @@
<% rubocop_version = Gem.loaded_specs.fetch("rubocop").version %>
+<% puts "RUBOCOP VERSION: #{rubocop_version}" %>
+<% puts "RUBOCOP-MINITEST VERSION: #{Gem.loaded_specs["rubocop-minitest"]&.version}" %>
% bundle binstubs rubocopbundle info
% bundle info rubocop | grep '*'
* rubocop (1.57.1)
% bundle info rubocop-minitest
Could not find gem 'rubocop-minitest'.gem info rubocop
% bundle exec gem info rubocop | grep '^rubocop'
rubocop (1.57.1)
% gem info rubocop | grep '^rubocop'
rubocop (1.57.2, 1.57.1, 1.56.4, 1.56.3, 1.56.2, 1.56.1, 1.55.1, 1.54.2, 1.54.1, 1.52.1, 1.52.0, 1.50.2, 1.50.0, 1.49.0, 1.30.1)gem info rubocop-minitest
% bundle exec gem info rubocop-minitest | grep '^rubocop'
% gem info rubocop-minitest | grep '^rubocop'
rubocop-minitest (0.32.2, 0.31.0)Running rubocop
% bundle exec rubocop | grep VERSION
RUBOCOP VERSION: 1.57.1
RUBOCOP-MINITEST VERSION:
% bin/rubocop | grep VERSION
RUBOCOP VERSION: 1.57.1
RUBOCOP-MINITEST VERSION:
% rubocop | grep VERSION
RUBOCOP VERSION: 1.57.2
RUBOCOP-MINITEST VERSION: 
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.56.4 to 1.57.1. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.56.4...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
This automated commit dumps the contents of the full RuboCop config. [dependabot skip]
This enables `Style/SingleLineDoEndBlock` for consumers on a new enough version of RuboCop. This allows us to enable the cop without dropping support for old RuboCop versions.
sambostock
force-pushed
the
dependabot/bundler/rubocop-1.57.1
branch
from
ad6545d to
194baa9
Compare
Bumps rubocop from 1.56.4 to 1.57.1.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
9141fe5Cut 1.57.1a302d0cUpdate Changelog12016d8[Fix #12271] Fix a false positive forLint/RedundantSafeNavigation128618cFix false positives forStyle/RedundantDoubleSplatHashBraces03cdf04Merge pull request #12267 from ydah/fix/122617edb5ca[Fix #12261] Fix an infinite loop forLayout/MultilineMethodCallIndentation42898bcMerge pull request #12266 from koic/fix_an_error_for_layout_multiline_method_...a4a505d[Fix #12265] Fix an error forLayout/MultilineMethodCallIndentation84840b8Fix typos873cb9fFix an incorrect autocorrect forStyle/RedundantExceptionwhen message is n...You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)