Allow def test_... lines to be long
#496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
config change
We currently allow lines like
test "a really really ... really long test name" do
using the Active Support declarative test style to violate
`Layout/LineLength`. It stands to reason we should also allow the
equivalent Minitest style
def test_a_really_really_..._really_long_test_name
sambostock
force-pushed
the
allow-long-lines-on-test-names
branch
from
20c4e61 to
1023d57
Compare
|
Good stuff! |
rafaelfranca
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently allow lines like
using the Active Support declarative test style to violate
Layout/LineLength. It stands to reason we should also allow the equivalent Minitest style