Build locations before creating entries #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
andyw8
reviewed
Oct 10, 2024
andyw8
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, our index entries accept either a
Prism::Locationor aRubyIndexer::Location. This is causing some weird patterns, like the need to pass the encoding everywhere even after the initial indexing has been performed.Prism is about to ship a new code units cache concept, which will hopefully solve the performance degradation we've been seeing, but it will also make our current design even more difficult to deal with.
This PR forces us to build locations outside of entries, which prevents the coupling with the encoding and makes the changes required much more straight forward.
Implementation
Every entry only accepts a
RubyIndexer::Locationnow. I added a helper method to build them from aPrism::Location, so that the transition to use the code units cache is easier.Automated Tests
Existing tests should cover it.