Use different error code for code action errors #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
andyw8
approved these changes
Sep 30, 2024
vinistock
force-pushed
the
vs-use-different-error-code-for-code-actions
branch
from
8f13d13 to
bd71b59
Compare
vinistock
force-pushed
the
vs-use-different-error-code-for-code-actions
branch
from
bd71b59 to
3d43f34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We keep seeing expected code action errors in our telemetry, which isn't useful. In fact, the only error code we want to send to telemetry is internal server error, which indicates a real bug.
Other codes are used to indicate things that aren't necessarily a bug in the implementation.
Implementation
Changed code actions resolve to stop raising and instead return a request failed error code. Also, started filtering the stuff sent to telemetry to only internal errors.