Allow declaration of project addons #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
vinistock
force-pushed
the
vs-allow-project-addons
branch
from
112041d to
f55f9c0
Compare
andyw8
reviewed
Sep 25, 2024
andyw8
reviewed
Sep 25, 2024
vinistock
force-pushed
the
vs-allow-project-addons
branch
from
f55f9c0 to
08008fc
Compare
vinistock
force-pushed
the
vs-allow-project-addons
branch
from
08008fc to
b0b8247
Compare
andyw8
approved these changes
Sep 25, 2024
vinistock
force-pushed
the
vs-allow-project-addons
branch
8 times, most recently
from
5d1f31b to
2fbb862
Compare
❌ Deploy Preview for ruby-lsp failed.
|
vinistock
force-pushed
the
vs-allow-project-addons
branch
2 times, most recently
from
28aeaa9 to
bd83a91
Compare
st0012
approved these changes
Oct 2, 2024
vinistock
force-pushed
the
vs-allow-project-addons
branch
4 times, most recently
from
f9ad63b to
dfced72
Compare
vinistock
force-pushed
the
vs-allow-project-addons
branch
from
7c50f3e to
1bb4eec
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Users may want to define project-specific addons for behaviour that only applies to a particular application. Supporting it is quite straight forward, so I think we should move forward and allow it.
Implementation
All of the mechanism to load the addons is already in place, the only limitation is that
Gem.find_fileswon't find files that aren't in gems.We just need to run a glob pattern on the workspace path to find project specific ones.
Automated Tests
Added a test.