Automatically switch overload in signature help #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
st0012
approved these changes
Sep 13, 2024
vinistock
force-pushed
the
vs-support-overloads-in-sig-help
branch
from
7707120 to
223bdfb
Compare
vinistock
force-pushed
the
vs-support-overloads-in-sig-help
branch
from
223bdfb to
7682a4a
Compare
Co-authored-by: Andy Waite <[email protected]>
vinistock
force-pushed
the
vs-support-overloads-in-sig-help
branch
from
7682a4a to
7208489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2363
Use the code we've been building for matching signatures to automatically detect which overload should appear in signature help based on the current arguments for a method call.
Implementation
The idea is that we now return all signatures instead of just the first one. Then we match the method call to find which signature is the one we should display.
Finally, we find the active parameter for that signature, so that it switches automatically too.
Automated Tests
Added a test.