Add keyword support to signature match #2546
Merged
+153
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Step towards #2363
This PR continues the work on #2541 and adds support for matching keyword parameters.
Implementation
The logic becomes a bit more complicated once we start mixing positionals with keywords and splats of both types.
The important thing to keep in mind is that this is going to be used to guess which overload to show in signature help, which means we need to do partial matching. For example:
Automated Tests
Added tests.