Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Ruby LSP extension's status item names #2484

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Aug 23, 2024

Motivation

Closes #2391

Screenshot 2024-08-23 at 22 04 47

Implementation

Automated Tests

Manual Tests

@st0012 st0012 added bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes labels Aug 23, 2024
@st0012 st0012 requested a review from a team as a code owner August 23, 2024 21:06
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but CI is breaking

@st0012 st0012 force-pushed the improve-status-item-names branch from 01d64c1 to 2661022 Compare August 23, 2024 21:08
@st0012 st0012 enabled auto-merge (squash) August 23, 2024 21:12
Copy link

@amomchilov amomchilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah perfect, thanks!

@st0012 st0012 merged commit e02ce6d into main Aug 23, 2024
34 checks passed
@st0012 st0012 deleted the improve-status-item-names branch August 23, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate all the status items into one
3 participants