Turn off semantic highlighting on files with more than 100k chars #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
|
Does the TS extension give any warning to the user that highlighting is disabled due to the filesize? |
vinistock
force-pushed
the
vs-disable-semantic-highlighting-large-files
branch
from
8a9a1fd to
211edf8
Compare
|
I'm not sure. But it does for other things. For example, I have already seen warnings related to folding ranges in very large JSON files. Do you think the warning is not necessary? |
|
Was just curious about the wording they used. |
andyw8
approved these changes
Aug 23, 2024
andyw8
reviewed
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2461
This PR disables semantic highlighting for documents with over 100k characters. The TypeScript extension does the same thing for performance reasons.
For very large files, it gets to a point where the editor is simply unable to process the amount of tokens returned by the server at an acceptable speed and everything starts to lag. Ideally, we'd still want to highlight large files, but it's better to have the other features working than to make the editor unusable in these situations.
This PR brings our responses down to 200ms for a ~4k line file.
Implementation
The idea is to show a warning when a document with more characters than the limit is opened and then we return empty responses before doing any processing if that's the case.
Automated Tests
Added a test.