Do not use the Sorbet runtime in the default load path #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
approved these changes
Jul 19, 2022
Morriar
reviewed
Jul 19, 2022
|
Our default require (lib/ruby-lsp.rb) doesn't actually require anything (not even dependencies like sorbet-runtime). All of our requires are in |
Morriar
approved these changes
Jul 19, 2022
vinistock
added a commit
that referenced
this pull request
Jul 27, 2022
…default_load_path Do not use the Sorbet runtime in the default load path
andyw8
pushed a commit
to andyw8/ruby-lsp
that referenced
this pull request
Mar 2, 2024
…sbuild-0.15.7 Bump esbuild from 0.15.6 to 0.15.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If people forget to use
require: falsewhen adding theruby-lspto theirGemfile, thenlib/ruby-lsp.rbwill be required by Bundler.We shouldn't use anything related to the Sorbet runtime in this file, because that would mean we have to require
sorbet-runtimeand possibly pollute the application in development mode.This is currently breaking in apps that do not use
sorbet-runtime, becauseT.letis not defined.Implementation
Ignored this file for the strict sigil cop and remove the
T.let.