Do not push ranges for single line comments #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
Jul 5, 2022
Morriar
approved these changes
Jul 5, 2022
paracycle
approved these changes
Jul 5, 2022
andyw8
pushed a commit
to andyw8/ruby-lsp
that referenced
this pull request
Mar 2, 2024
…ypescript-eslint/parser-5.33.0 Bump @typescript-eslint/parser from 5.32.0 to 5.33.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were pushing single line partial ranges in response but they're not used by VSCode for anything so now we are skipping them.
Implementation
Added
multiline?function toPartialRangeclass to check if the partial was multiline and include if it is.Automated Tests
Added in
single_comment.rbfixture which is just a single comment that does not get checked. All other tests passing.