Include all token types in legend #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
approved these changes
Jul 4, 2022
Morriar
approved these changes
Jul 5, 2022
andyw8
pushed a commit
to andyw8/ruby-lsp
that referenced
this pull request
Mar 2, 2024
…ypes/node-18.6.5 Bump @types/node from 18.6.3 to 18.6.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add all token types from the LSP specification in our legend, similar to what we're doing for modifiers and for symbol types in document symbol. This is mostly for consistency, but also so that we have the full list available when handling new tokens.
Implementation
Automated Tests
Updated tests to reflect the change in token indices.
Manual Tests
There shouldn't be any functional change.