Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic highighting for def endless and singleton method names #134

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

wildmaples
Copy link
Contributor

Motivation

More semantic highlighting for method names of: def endless and singleton

Implementation

Create a visit method for both these types of methods

Automated Tests

Added new expectation file for semantic highlighting tests for the two new cases

Manual Tests

Turn on VS Code's editor token and scope mode:

def baz = 10

def self.foo
  a = 2
  puts "a"
end

Screen Shot 2022-06-08 at 9 34 06 AM

Screen Shot 2022-06-08 at 9 33 34 AM

@wildmaples wildmaples added the enhancement New feature or request label Jun 8, 2022
@wildmaples wildmaples requested a review from a team June 8, 2022 13:37
@wildmaples wildmaples self-assigned this Jun 8, 2022
@wildmaples wildmaples force-pushed the sh-def-endless-and-singleton branch 2 times, most recently from 31d4f4d to d0d1e6f Compare June 8, 2022 16:43
@wildmaples wildmaples force-pushed the sh-def-endless-and-singleton branch from d0d1e6f to 85ffe6b Compare June 8, 2022 16:45
@wildmaples wildmaples requested a review from Morriar June 8, 2022 16:48
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, once the order of visits concern is addressed

@wildmaples
Copy link
Contributor Author

Good to go, once the order of visits concern is addressed

Already done! I fixed up the change

Base automatically changed from highlight-def to main June 8, 2022 19:41
@wildmaples wildmaples merged commit c594916 into main Jun 9, 2022
@wildmaples wildmaples deleted the sh-def-endless-and-singleton branch June 9, 2022 00:14
@shopify-shipit shopify-shipit bot temporarily deployed to production June 15, 2022 15:46 Inactive
andyw8 pushed a commit to andyw8/ruby-lsp that referenced this pull request Mar 2, 2024
…ypescript-eslint/parser-5.30.0

Bump @typescript-eslint/parser from 5.29.0 to 5.30.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants