Move codebase to typed strict #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
reviewed
Jun 6, 2022
vinistock
force-pushed
the
vs/get_codebase_to_typed_strict
branch
from
3bf0c7c to
0d42475
Compare
Morriar
reviewed
Jun 7, 2022
vinistock
force-pushed
the
vs/get_codebase_to_typed_strict
branch
from
99f0b94 to
280faf8
Compare
Morriar
approved these changes
Jun 8, 2022
vinistock
force-pushed
the
vs/get_codebase_to_typed_strict
branch
from
280faf8 to
af95f0c
Compare
wildmaples
approved these changes
Jun 9, 2022
RyanBrushett
approved these changes
Jun 9, 2022
andyw8
referenced
this pull request
in andyw8/ruby-lsp
Mar 2, 2024
…de-18.0.0 Bump @types/node from 17.0.44 to 18.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The final PR in our efforts to adopt Sorbet. This PR enforces typed strict in our files (except for test files, which are enforced as typed true).
Implementation
Split by commit
Let me know what you think about the generics. I don't love it, but they did improve typing and actually helped me find an incorrect signature in
Handler.