Add Sorbet to the Ruby LSP #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
reviewed
May 31, 2022
Morriar
reviewed
May 31, 2022
paracycle
approved these changes
May 31, 2022
There was a problem hiding this comment.
Thank you, this looks good. Should we disable runtime type-checking when the CLI is called like how we do in Tapioca (as part of a followup PR) to limit the runtime overhead on the executable?
Morriar
approved these changes
May 31, 2022
|
@paracycle yes, I'll add it to the follow up PR. |
st0012
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
First step in #62
Add Sorbet with all sigils as typed false.
I'll follow this one with a PR to change the sigils and add more typing.
Implementation
I tried ordering the commits, so that the changes are easier to review. But it's basically