Always push telemetry/event notifications #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
approved these changes
May 27, 2022
vinistock
force-pushed
the
vs/always_push_telemetry_events
branch
from
27caa48 to
daf4c6b
Compare
vinistock
force-pushed
the
vs/always_push_telemetry_events
branch
from
daf4c6b to
be9284f
Compare
|
@paracycle in the second commit, I have refactored the |
Morriar
approved these changes
May 31, 2022
paracycle
approved these changes
May 31, 2022
st0012
approved these changes
May 31, 2022
andyw8
referenced
this pull request
in andyw8/ruby-lsp
Mar 2, 2024
…pt-4.7.3 Bump typescript from 4.7.2 to 4.7.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This work is necessary to help address the problem described in Shopify/vscode-ruby-lsp#85.
It's brittle to let the plugin tell the server if
telemetry/eventnotifications should be pushed or not. It's more robust to always send the notifications and just let the plugin decide whether to discard or do something with them.Implementation
Removed the check for whether telemetry was enabled or not and also removed the ignored requests logic. It's much simpler to just send everything to the plugin and let it decide.
Automated Tests
Added the extra assertions expected from always sending telemetry notifications.
Manual Tests