Merge pull request #216 from Shopify/vs/return_nil_if_document_is_alr…

…eady_formatted Return nil if document is already formatted
Shopify · Jul 25, 2022 · 00a5508 · 00a5508
2 parents fc780ae + 07c455b
commit 00a5508
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/ruby_lsp/requests/formatting.rb b/lib/ruby_lsp/requests/formatting.rb
@@ -34,6 +34,7 @@ def run
         return unless formatted_text
 
         size = @document.source.size
+        return if formatted_text.size == size && formatted_text == @document.source
 
         [
           LanguageServer::Protocol::Interface::TextEdit.new(

diff --git a/test/requests/formatting_test.rb b/test/requests/formatting_test.rb
@@ -36,6 +36,19 @@ def foo
     end
   end
 
+  def test_returns_nil_if_document_is_already_formatted
+    document = RubyLsp::Document.new(+<<~RUBY)
+      # typed: strict
+      # frozen_string_literal: true
+
+      class Foo
+        def foo
+        end
+      end
+    RUBY
+    assert_nil(RubyLsp::Requests::Formatting.new("file://#{__FILE__}", document).run)
+  end
+
   private
 
   def with_uninstalled_rubocop(&block)