Only display code lens when the test framework is rails #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, ruby-lsp-rails also sends code lens even when the test library is not rails. This creates problem when the user has both ruby-lsp-rspec and ruby-lsp-rails installed and the test framework is rspec, as the duplicated code lens will be cause none of them to display.
st0012
commented
Apr 3, 2024
| @@ -47,6 +47,8 @@ def deactivate | |||
| ).void | |||
| end | |||
| def create_code_lens_listener(response_builder, uri, dispatcher) | |||
| return unless T.must(@global_state).test_library == "rails" | |||
There was a problem hiding this comment.
I decided to skip the entire listener because it's only used for test code lends atm.
There was a problem hiding this comment.
That's probably fine for now, but we'll need to re-think for @gmcgibbon's work in #239
There was a problem hiding this comment.
I may be worth creating a separate listener for that feature now that we have conditions like this.
andyw8
approved these changes
Apr 3, 2024
|
We still need to improve the test framework detection logic in the Ruby LSP to fully fix the Ruby LSP RSpec issue though, right? |
|
@vinistock Yeah that's true. I'm working on it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ruby-lsp-rails also sends code lens even when the test library is not rails. This creates problem when the user has both ruby-lsp-rspec and ruby-lsp-rails installed and the test framework is rspec, as the duplicated code lens will be cause none of them to display.
I also removed obsolete test setups that create/remove message queues manually. They're not used after the
with_serveris adopted.