Use add_global_offense for ForbidRBIOutsideOfAllowedPaths
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous `add_offense` errors when the file is empty: Range 0..1 makes no sense in that context. `add_global_offense` was added for Rubocop v1 which is great since 1.0.0 is now the minimum required version
KaanOzkan
approved these changes
Jul 30, 2024
|
This makes me realize that Ruby LSP doesn't have a way to show 'global' offenses: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
add_offenseerrors when the file is empty: Range 0..1 makes no sense in that context. The error occurs during output:add_global_offensewas added for Rubocop v1 which is great since 1.0.0 is now the minimum required version.Why even bother?
I created a new rbi file for testing and
ruby-lspruns over it with rubocop immediatly which means it will error.