Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React Native to 0.72 #278

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Upgrade React Native to 0.72 #278

merged 8 commits into from
Apr 4, 2024

Conversation

migueldaipre
Copy link
Contributor

@migueldaipre migueldaipre commented Oct 9, 2023

Description

Possible fixes (issue #274)

This PR upgrades the React Native version to the latest 0.72. It also fixes all typescript, eslint, and testing errors related to the upgrade.

Reviewers’ hat-rack 🎩

  • run the fixtures app and everything should work as expected

Video

restyle-update-rn-0.72.mp4

Checklist

@migueldaipre migueldaipre closed this by deleting the head repository Dec 5, 2023
@migueldaipre migueldaipre reopened this Dec 5, 2023
@gvarandas
Copy link
Contributor

@migueldaipre could you resolve the conflicts and sign the CLA so we can get this in? 🙏

@migueldaipre
Copy link
Contributor Author

I have signed the CLA!

@migueldaipre
Copy link
Contributor Author

Done @gvarandas

@migueldaipre
Copy link
Contributor Author

How should I change the changelog?

@gvarandas gvarandas self-requested a review March 21, 2024 17:21
@gvarandas
Copy link
Contributor

So, I was just testing your PR and it seems like we're missing a few pieces to make sure things work 100% as we'd expect:

  • The fixture app is set up using an old version of react-native-test-app, so we should probably update it (^3.4.3 seems like the latest)
    • With that change some of the app's setup is also changed (Gradle files, react-native-config.json, etc), so we might need to revamp it as well
  • Running pod install relies on having a global version of cocoapods installed, which isn't great, so we should probably add a Gemfile to the fixture folder as well that installs it.

I've applied the changes to this branch (fixture_72), if you want to take a look and test it. Might be easy enough to add it to your PR so we can get it merged sooner than later 🙇

@migueldaipre
Copy link
Contributor Author

Hey @gvarandas, I took a look and it worked perfectly for me.

@gvarandas
Copy link
Contributor

@migueldaipre do you mind adding that commit to your PR then, so we can get it in?

@migueldaipre
Copy link
Contributor Author

@gvarandas Done 🎉

@gvarandas gvarandas merged commit 58bdd5d into Shopify:master Apr 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants