Handle Pressable function style prop #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey @codybrouwers, thanks for looking into this! The solution looks fine but it currently throws some typescript errors because the style prop is typed as Could you have a look at fixing that? |
|
@sbalay sure thing, will take a look this weekend! |
|
@sbalay Made some adjustments and got all of the types working, let me know what you think! |
|
Thanks @codybrouwers! I'll have a look during this week. |
anaibol
approved these changes
Apr 5, 2022
codybrouwers
commented
Apr 6, 2022
src/hooks/useRestyle.ts
Outdated
| return [style, props.style].filter(Boolean); | ||
| const styleProp = props.style; | ||
| if (typeof styleProp === 'function') { | ||
| return (...args: any[]) => [style, styleProp(...args)]; |
There was a problem hiding this comment.
Maybe it is worth having the .filter(Boolean) on this returned array as well?
sbalay
approved these changes
Apr 11, 2022
|
should we revert this PR in order to solve #159 ? |
|
Agree, @sbalay would that be possible to revert this change or rewrite in a way that doesn't break typesafety? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using the style prop along with Restyle provided props, only style objects are accepted but the Pressable component also accepts a function in order to access the
pressedstate.This PR detects if the style prop is a function and if so, returns another function that merges the Restyle generated styles and the style prop styles.
I just threw together this fix in a few minutes so maybe there is some edge cases I haven't thought of, feel free to disregard if the problem is actually a lot harder then my small fix. It does work locally for me at least.
Thanks!
Should resolve #58